nielsbasjes commented on a change in pull request #11245: [FLINK-15794][Kubernetes] Generate the Kubernetes default image version URL: https://github.com/apache/flink/pull/11245#discussion_r396501695
########## File path: docs/ops/deployment/kubernetes.md ########## @@ -112,8 +112,8 @@ An early version of a [Flink Helm chart](https://github.com/docker-flink/example ### Session cluster resource definitions -The Deployment definitions use the pre-built image `flink:latest` which can be found [on Docker Hub](https://hub.docker.com/r/_/flink/). -The image is built from this [Github repository](https://github.com/docker-flink/docker-flink). +The Deployment definitions use the pre-built image `flink:{{ site.version }}-scala_2.12` (or `flink:{{ site.version }}-scala_2.11`) which can be found [on Docker Hub](https://hub.docker.com/_/flink/). Review comment: As a rule for myself I always try to make the documentation match the change I'm writing. In this case for me this is really about avoiding the extremely obscure errors you get if you use the wrong Scala version docker image. So in this case to me this documentation seemed like it needed to be fixed as well as part of this change set. Side note: Given that the flink docker image must match both the Flink version and Scala version used by my application to run successfully: I would vote to completely drop all docker tags that do not explicitly specify both Flink and Scala versions (i.e. no more `latest` , `scala_2.12` or `1.10.0` tags). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
