afedulov commented on a change in pull request #11195: [FLINK-16222][runtime]
Use plugins mechanism for initializing MetricReporters
URL: https://github.com/apache/flink/pull/11195#discussion_r396809894
##########
File path:
flink-end-to-end-tests/flink-metrics-reporter-prometheus-test/src/test/java/org/apache/flink/metrics/prometheus/tests/PrometheusReporterEndToEndITCase.java
##########
@@ -120,24 +122,51 @@ public static void checkOS() {
public final DownloadCache downloadCache = DownloadCache.get();
@Test
- public void testReporter() throws Exception {
- dist.copyOptJarsToLib("flink-metrics-prometheus");
+ public void reporterWorksWhenFoundInLibsViaReflection() throws
Exception {
+ dist.copyOptJarsToLib(PROMETHEUS_JAR_PREFIX);
Review comment:
@zentol It seems that this updated approach that got merged into master does
not support the kinds of tests that we would need to do for the supported
scenarios (see reporterWorksWhenFoundInLibsViaReflection,
reporterWorksWhenFoundInPluginsViaReflection,
reporterWorksWhenFoundBothInPluginsAndLibsViaFactories in this PR). How should
we proceed? I can either bend the FlinkResource implementation back to the
state where it supports modifications of the underlying resources after
creation and keep the initialization in `@Rule` (a hack), or reinitizliae
FlinkResource in every test (probably a bad idea from performance and overhead
perspectives). What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
