xintongsong commented on a change in pull request #11284:
[FLINK-15911][runtime] Make Flink work with NAT.
URL: https://github.com/apache/flink/pull/11284#discussion_r396891883
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/KvStateService.java
##########
@@ -181,7 +181,7 @@ public static KvStateService
fromConfiguration(TaskManagerServicesConfiguration
int numStateServerQueryThreads =
qsConfig.numStateQueryThreads() == 0 ?
taskManagerServicesConfiguration.getNumberOfSlots() :
qsConfig.numStateQueryThreads();
kvStateServer = QueryableStateUtils.createKvStateServer(
Review comment:
I have no opinion on this.
I'm not familiar with how the queryable state works and its use cases. I've
consulted @zhijiangW about this, and he suggested that queryable state does not
have much use cases and may not be necessary for the NAT scenarios.
In addition, if we want to support this for queryable state, we could use
some help from people who are more familiar with the queryable state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
