[
https://issues.apache.org/jira/browse/FLINK-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045048#comment-15045048
]
ASF GitHub Bot commented on FLINK-3113:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1435#issuecomment-162549415
+1, please merge
Should we also remove the DataDistribution class? We can revamp it in a
better form with the global sorting pull request...
> Remove unused global order methods from GenericDataSinkBase
> -----------------------------------------------------------
>
> Key: FLINK-3113
> URL: https://issues.apache.org/jira/browse/FLINK-3113
> Project: Flink
> Issue Type: Task
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Fabian Hueske
> Assignee: Fabian Hueske
> Priority: Minor
> Fix For: 1.0.0
>
>
> The {{GenericDataSinkBase}} class has unused methods to specify a global
> order. These methods are an artifact of the recently removed Record API and
> not suitable for the current DataSet API because they lack the definition of
> a key.
> The following methods and fields should be removed from
> {{GenericDataSinkBase}}
> - {{partitioningOrdering}}
> - {{distribution}}
> - {{setGlobalOrder()}}
> - {{setRangePartitioned()}}
> - {{getPartitiningOrdering()}}
> - {{getDataDistribution()}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
