pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399246867
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/InputChannelInfo.java
##########
@@ -20,14 +20,15 @@
import org.apache.flink.annotation.Internal;
import java.io.Serializable;
+import java.util.Objects;
/**
* Identifies {@link
org.apache.flink.runtime.io.network.partition.consumer.InputChannel} in a given
subtask.
* Note that {@link
org.apache.flink.runtime.io.network.partition.consumer.InputChannelID
InputChannelID}
* can not be used because it is generated randomly.
*/
@Internal
-public class InputChannelInfo implements Serializable {
+public final class InputChannelInfo implements Serializable {
Review comment:
nitty nit: how does making those classes `final` make them easier to test?
Maybe add a description in the commit message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
