[
https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045351#comment-15045351
]
ASF GitHub Bot commented on FLINK-7:
------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1255#issuecomment-162608149
Hi @ChengXiangLi, I tried the PR locally on my machine and it was working
quite well.
I found a few minor issues:
- You don't need to set keys and sort order for `FORWARD` shipping
strategies in `RangePartitionRewriter` line 118
- You set the `DataExchangeMode` twice in line 163 and 166 or
`RangePartitionRewriter`
- We need to set costs and properties for the PlanNodes that we create.
Otherwise `ExecutionEnvironment.getExecutionPlan()` fails with a NPE. Costs can
be 0, IMO but we should set the correct physical properties because these are
visualized and might confuse users.
- The injected plan node should have good names that indicate that they
belong to the range partitioner. I suggest:
- `sipPlanNode`: "RangePartition: LocalSample"
- `sicPlanNode`: "RangePartition: GlobalSample"
- `rbPlanNode`: "RangePartition: Histogram"
- `ariPlanNode`: "RangePartition: Partition"
- `prPlanNode`: "RangePartition: Partition" (IMO its fine to have the
same name here. Too much detail such as assign id and unwrap might just confuse)
What do you think?
> [GitHub] Enable Range Partitioner
> ---------------------------------
>
> Key: FLINK-7
> URL: https://issues.apache.org/jira/browse/FLINK-7
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Runtime
> Reporter: GitHub Import
> Assignee: Chengxiang Li
> Fix For: pre-apache
>
>
> The range partitioner is currently disabled. We need to implement the
> following aspects:
> 1) Distribution information, if available, must be propagated back together
> with the ordering property.
> 2) A generic bucket lookup structure (currently specific to PactRecord).
> Tests to re-enable after fixing this issue:
> - TeraSortITCase
> - GlobalSortingITCase
> - GlobalSortingMixedOrderITCase
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/7
> Created by: [StephanEwen|https://github.com/StephanEwen]
> Labels: core, enhancement, optimizer,
> Milestone: Release 0.4
> Assignee: [fhueske|https://github.com/fhueske]
> Created at: Fri Apr 26 13:48:24 CEST 2013
> State: open
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
