tzulitai opened a new pull request #78: [FLINK-16838] Change base image name and apply versioning URL: https://github.com/apache/flink-statefun/pull/78 This PR has the following end-goal in mind: - Examples / E2E tests / quickstart archetype built or run from snapshot versions (i.e. from `master` or `release-2.0` branches) should always run against a locally-built StateFun base image, built from the source of said snapshot version. - Released examples / E2E tests / quickstart archetypes, should not require users to locally build a StateFun image, assuming that we will have official images published to Docker Hub. This PR does a few things to accomplish that: 1. Let the image build script `tools/docker/build-distribution.sh` build images tagged with the current source version. i.e., `2.1-SNAPSHOT` when built from the snapshot `master` branch, `2.0-SNAPSHOT` when built from the snapshot `release-2.0` branch, or simply `2.0.0` if built from a officially released source distribution 2. Update Dockerfiles of all examples / E2E tests / quickstart archetype to use a specific version tag. This has the effect that, if those were built from a released distribution, the image may be pulled directly from Docker Hub (when we publish the images after the release). Otherwise, if those were built from a snapshot version, they would use a locally-built snapshot image. On the side, this PR also uses the opportunity to rename the image name from `statefun` to `flink-statefun`, with the following reasoning: - It would be more consistent with the naming convention of other distributions, like the Python SDK - Lets the image name to show association with Flink --- ## Verifying I verified the changes by: - Running all the examples that used images built from StateFun base image, and all ran without problems - Run all end-to-end tests, using `mvn clean verify -Prun-e2e-tests` - Created new project from quickstart archetype - the generated skeleton project has correct Dockerfiles
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
