tzulitai edited a comment on issue #79: [FLINK-16730][docs] Add walkthrough distribution as build step URL: https://github.com/apache/flink-statefun/pull/79#issuecomment-605554070 After some time thinking about this, I think we probably shouldn’t rush adding the zip dist building as a Maven build step. The problem is: every time you do a `mvn clean package`, it generates a git diff with the regenerated zip file, even if the contents are actually identical. It’ll be a bit confusing. We could add that build step behind a Maven profile that developers have to enable to build the doc walkthrough dists, but that’s almost the same work for devs as just manually executing the script. For now, lets proceed like so: - Only generate the wallthrough zip in the docs buildbot (using the old `docs/download/build-walkthrough.sh`) and have that published with the docs. That’s the only time it’ll really be needed to be checked for an update, anyways. When building the docs locally, that download link will be broken, but I think that’s fine for now. - That means I’ll be removing the Maven build step + zip from the repo + remain excluded in the .gitignore. - Lets revisit this once we realize we need more and more Python zip dists in the docs Sorry for the back and forth on the solution, but after some thinking I think this is the safest approach to take first.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
