pnowojski commented on issue #11541: [FLINK-15416][network] add task manager netty client retry mechenism URL: https://github.com/apache/flink/pull/11541#issuecomment-606051120 > This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work. Please next time do not start work before being assigned to the ticket. Especially that there was my unresolved question in the Jira ticket whether we want to have such change or not. In the end I think we can go in the direction of supporting retry mechanism in the network stack (including TCP connection loss in the middle of transfer), so we can just as well start with the reconnection retries as you are proposing. I will give more detailed look at your PR later. For starter, could you try to provide unit tests for the `PartitionRequestClientFactory` class? For example by mocking `NettyClient`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
