zhijiangW commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r400643335
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -210,4 +214,12 @@ public String toString() {
", isRegisteredAsAvailable=" + isRegisteredAsAvailable +
'}';
}
+
+ @Override
+ public EnqueueAction priorityEvent(AbstractEvent event, BufferConsumer
eventBufferConsumer) {
+ // make sure netty consumer knows that it can immediately
process next buffer
+ notifyDataAvailable();
Review comment:
I think it is not necessary to call `notifyDataAvailable` here. The event
actually has not been added into queue yet, so the netty thread can not fetch
data immediately, even I am not sure it might bring mistake here. And after
adding event into queue inside `PipelinedSubpartition`, the
`notifyDataAvailable` would be called in normal way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
