zhijiangW commented on a change in pull request #11515: [FLINK-16744][task]
implement channel state persistence for unaligned checkpoints
URL: https://github.com/apache/flink/pull/11515#discussion_r401339591
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SourceTaskTerminationTest.java
##########
@@ -82,7 +84,7 @@ private void stopWithSavepointStreamTaskTestHelper(final
boolean withMaxWatermar
final Thread executionThread = srcTaskTestHarness.invoke();
final StreamTask<Long, ?> srcTask =
srcTaskTestHarness.getTask();
- ready.await();
+ waitForLatchSetByTask(ready, srcTaskTestHarness);
Review comment:
I did not get the point why we need this change and it seems unrelated to
this PR. If the motivation is for avoiding stuck long time during `await()`,
but it already has `timeoutPerTest` for ending the test after timeout.
If we want to refactor some previous tests, it should be a `hotfix` commit
if minor and give some descriptions in commit message for better understanding
the motivation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
