zhijiangW commented on a change in pull request #11515: [FLINK-16744][task] implement channel state persistence for unaligned checkpoints URL: https://github.com/apache/flink/pull/11515#discussion_r401359992
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ########## @@ -89,17 +101,98 @@ public void checkpointState( checkpointMetaData.getCheckpointId(), checkpointOptions.getTargetLocation()); - CheckpointingOperation.execute( - checkpointMetaData, - checkpointOptions, - checkpointMetrics, - storage, - operatorChain, - taskName, - closeableRegistry, - executorService, - env, - asyncExceptionHandler, - isCanceled); + long startSyncPartNano = System.nanoTime(); Review comment: nit: better to extract a separate method for the following operation, otherwise this method seems too long for not easy tracing the steps. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services