zentol commented on a change in pull request #11586: [FLINK-5552][runtime] make JMXServer static per JVM URL: https://github.com/apache/flink/pull/11586#discussion_r402181978
########## File path: flink-core/src/main/java/org/apache/flink/configuration/JMXServerOptions.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.configuration; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.annotation.docs.Documentation; + +import static org.apache.flink.configuration.ConfigOptions.key; + +/** + * The set of configuration options relating to heartbeat manager settings. + */ +@PublicEvolving +public class JMXServerOptions { + + /** Port configured to enable JMX server for metrics and debugging. */ + @Documentation.Section(Documentation.Sections.COMMON_MISCELLANEOUS) + public static final ConfigOption<String>JMX_SERVER_PORT = + key("jmx.server.port") + .defaultValue("-1") + .withDescription("The port range for the JMX server to start the registry. The " + + "port config can be a single port: \"9123\", a range of ports: \"50100-50200\", " + + "or a list of ranges and ports: \"50100-50200,50300-50400,51234\".") + .withDeprecatedKeys("metrics.reporter.my_jmx_reporter.port"); Review comment: I would suggest the following: - "deprecate" the JMX reporter option, as in, use the new option by default with a fallback on the old one, add a note into the description of `jmx.port`that this option overrides the port option of the JMX reporter ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
