zhijiangW commented on a change in pull request #11515: [FLINK-16744][task]
implement channel state persistence for unaligned checkpoints
URL: https://github.com/apache/flink/pull/11515#discussion_r402276598
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriter.java
##########
@@ -46,60 +78,64 @@
/**
* Initiate write of channel state for the given checkpoint id.
*/
- void start(long checkpointId);
+ void start(long checkpointId, CheckpointOptions checkpointOptions);
/**
* Add in-flight buffers from the {@link
org.apache.flink.runtime.io.network.partition.consumer.InputChannel
InputChannel}.
- * Must be called after {@link #start(long)} and before {@link
#finish(long)}.
+ * Must be called after {@link #start} (long)} and before {@link
#finishInput(long)}.
Review comment:
#start misses one argument
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
