AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic 
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r402588442
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -845,21 +845,19 @@ public ExecutorService getAsyncOperationsThreadPool() {
 
        private void notifyCheckpointComplete(long checkpointId) {
                try {
-                       boolean success = actionExecutor.call(() -> {
 
 Review comment:
   `actionExecutor` is only meaningful for legacy sources and acquires 
checkpoint lock. We cannot remove it for `performCheckpoint` as it could be 
called from barrier handler via `triggerCheckpointOnBarrier`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to