xintongsong commented on a change in pull request #11615: [FLINK-16605] Add max
limitation to the total number of slots
URL: https://github.com/apache/flink/pull/11615#discussion_r402718103
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/ClusterOptions.java
##########
@@ -69,4 +69,11 @@
.text("Enable the slot spread out allocation
strategy. This strategy tries to spread out " +
"the slots evenly across all available
%s.", code("TaskExecutors"))
.build());
+
+ @Documentation.Section(Documentation.Sections.EXPERT_SCHEDULING)
+ public static final ConfigOption<Integer> MAX_SLOT_NUM = ConfigOptions
+ .key("cluster.number-of-slots.max")
+ .intType()
+ .defaultValue(Integer.MAX_VALUE)
+ .withDescription("Defines the max limitation of the total
number of slots.");
Review comment:
I think we should add this to `ResourceManagerOptions` rather than
`ClusterOptions`, with key prefix `slotmanager.*`. The option is only used in
`SlotManager`, and once FLINK-14106 is finished this might even become a
plugin-specific config option.
And I would also mention in the description that this is meant for batch
scenarios and might cause problems on streaming jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
