HuangZhenQiu commented on a change in pull request #11541:
[FLINK-15416][network] add task manager netty client retry mechenism
URL: https://github.com/apache/flink/pull/11541#discussion_r402815267
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactoryTest.java
##########
@@ -130,6 +130,23 @@ public void run() {
}
}
+ @Test
+ public void testNettyClientConnectRetry() throws Exception {
+ NettyClient nettyClient = mock(NettyClient.class);
Review comment:
I think it will be better. But when I try to implement the
TestingNettyClient, I found the SucceededChannelFuture only visible to package
io.netty.channel. Thus, I need to create a new class of SucceededChannelFuture
in Flink to return a success ChannelFuture. Do you think it is a right way to
go?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
