azagrebin commented on a change in pull request #11624: [FLINK-16949] Enhance
AbstractStreamOperatorTestHarness to use customized TtlTimeProvider
URL: https://github.com/apache/flink/pull/11624#discussion_r402916524
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamTaskStateInitializerImpl.java
##########
@@ -258,6 +258,10 @@ protected OperatorStateBackend operatorStateBackend(
}
}
+ protected TtlTimeProvider getTtlTimeProvider() {
Review comment:
I think either approach can be refactored in future.
Using constructor is the usual way how we inject dependencies for tests. The
inheritance is usually used to change more complicated internal behaviour.
You could also keep the current constructor and add another one annotated
with @VisibleForTesting which could accept the custom `TtlTimeProvider` field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
