tillrohrmann commented on a change in pull request #11353: [FLINK-16438][yarn]
Make YarnResourceManager starts workers using WorkerResourceSpec requested by
SlotManager
URL: https://github.com/apache/flink/pull/11353#discussion_r403083789
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManager.java
##########
@@ -183,16 +178,18 @@ public boolean stopWorker(final KubernetesWorkerNode
worker) {
@Override
public void onAdded(List<KubernetesPod> pods) {
runAsync(() -> {
- for (KubernetesPod pod : pods) {
- if (numPendingPodRequests > 0) {
- numPendingPodRequests--;
+ pods.forEach(pod -> {
Review comment:
Call me old fashioned, but I think the for-each loop `for (KubernetesPod
pod: pods)` is superior to `forEach`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
