tillrohrmann commented on issue #11320: [FLINK-16437][runtime] Make SlotManager 
allocate resource from ResourceManager at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#issuecomment-609814865
 
 
   I see your point @xintongsong and agree that the caller (`SlotManager`) 
should not call the `RM` with some invalid value. I guess what we would really 
need is an `ActiveSlotManager` and a `SlotManager` which cannot and won't try 
to allocate new resources.
   
   Why is it that the standalone `SlotManager` cannot generate a 
`WorkerResourceSpec`? Shouldn't we be able to calculate it? Given that the 
actual value should not matter, we could also default to some random/arbitrary 
value.
   
   If this is not possible, then I'm ok with adding a 
`DefaultWorkerSlotResourceProvider` and having a 
`DefaultWorkerSlotResourceProvider.NO_RESOURCES` or so.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to