AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r404303608
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
##########
@@ -184,17 +184,18 @@ public ShuffleIOOwnerContext createShuffleIOOwnerContext(
}
@Override
- public Collection<ResultPartition> createResultPartitionWriters(
Review comment:
Hm seems like my response got lost.
In general, `Collection` gives no ordering guarantees. If the using code
breaks if we return a `HashSet` instead of an `ArrayList`, then it's the wrong
interface. We have been sloppy with this distinction in the past and I wanted
to make it very explicit for our deep change into how channels are working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
