TisonKun commented on a change in pull request #11456: [FLINK-16602][k8s]
Rework the internal/external Service
URL: https://github.com/apache/flink/pull/11456#discussion_r404608575
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/factory/KubernetesJobManagerFactoryTest.java
##########
@@ -179,8 +180,9 @@ public void testServices() {
final Service resultInternalService =
internalServiceCandidates.get(0);
assertEquals(2,
resultInternalService.getMetadata().getLabels().size());
- assertEquals(resultInternalService.getSpec().getType(),
"ClusterIP");
- assertEquals(3,
resultInternalService.getSpec().getPorts().size());
+ assertNull(resultInternalService.getSpec().getType());
+ assertEquals("None",
resultInternalService.getSpec().getClusterIP());
Review comment:
Also update literal `"None"` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
