zentol commented on a change in pull request #11639: [FLINK-16626][runtime]
Prevent REST handler from being closed more than once
URL: https://github.com/apache/flink/pull/11639#discussion_r404589667
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java
##########
@@ -271,6 +273,24 @@ public void testDetachedJobSubmission() throws Exception {
}
+ /**
+ * Tests that ensure each handler is registered only once.
+ */
+ @Test
+ public void testDuplicatedHandlerRegistration() throws Exception {
+ final TestJobSubmitHandler testJobSubmitHandler = new
TestJobSubmitHandler();
+
+ assertThrows("Duplicate REST handler instance found. Please
ensure each instance is registered only once.",
+ FlinkRuntimeException.class,
+ () -> {
+ try (TestRestServerEndpoint restServerEndpoint
= createRestServerEndpoint(
Review comment:
We are leaking resources here since we never actually get back a
`restServerEndpoint`; `createRestServerEndpoint` fails with an exception but
doesn't close the resource internally if `start()` fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
