AHeise commented on a change in pull request #11515: [FLINK-16744][task] implement channel state persistence for unaligned checkpoints URL: https://github.com/apache/flink/pull/11515#discussion_r404999440
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutor.java ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.checkpoint.channel; + +import java.io.Closeable; + +/** + * Executes {@link ChannelStateWriteRequest}s potentially asynchronously. An exception thrown during the execution + * should be re-thrown on any next call. + */ +interface ChannelStateWriteRequestExecutor extends Closeable { + + /** + * @throws IllegalStateException if called more than once or after {@link #close()} + */ + void start() throws IllegalStateException; + + /** + * Send {@link ChannelStateWriteRequest} to this worker. If this method throws an exception then client must + * {@link ChannelStateWriteRequest#cancel cancel} it. + * @throws IllegalStateException if worker is not running + * @throws Exception if any exception occurred during processing this or other items previously + */ + void submit(ChannelStateWriteRequest r) throws Exception; + + /** + * Send {@link ChannelStateWriteRequest} to this worker to be processed first. If this method throws an exception then client must + * {@link ChannelStateWriteRequest#cancel cancel} it. + * @throws IllegalStateException if worker is not running + * @throws Exception if any exception occurred during processing this or other items previously + */ + void submitPriority(ChannelStateWriteRequest r) throws Exception; + Review comment: nit: you don't use empty lines on other classes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
