Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1451#discussion_r47536514
--- Diff:
flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/ZookeeperOffsetHandler.java
---
@@ -61,30 +61,29 @@ public ZookeeperOffsetHandler(Properties props) {
if (zkConnect == null) {
throw new IllegalArgumentException("Required property
'zookeeper.connect' has not been set");
}
-
- zkClient = new ZkClient(zkConnect,
-
Integer.valueOf(props.getProperty("zookeeper.session.timeout.ms", "6000")),
-
Integer.valueOf(props.getProperty("zookeeper.connection.timeout.ms", "6000")),
- new ZooKeeperStringSerializer());
+
+ RetryPolicy retryPolicy = new ExponentialBackoffRetry(100, 10);
+ curatorClient = CuratorFrameworkFactory.newClient(zkConnect,
retryPolicy);
--- End diff --
Good point. I'm now allowing users to change the default values. (I chose
to use the curator defaults rather than the kafka defaults). The retry policy
is also configurable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
