azagrebin commented on a change in pull request #11427: [FLINK-15790][k8s] Make
FlinkKubeClient and its implementations asynchronous
URL: https://github.com/apache/flink/pull/11427#discussion_r405353674
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesTestBase.java
##########
@@ -84,7 +85,10 @@ public void setup() throws Exception {
TestBaseUtils.setEnv(map);
kubeClient = server.getClient().inNamespace(NAMESPACE);
- flinkKubeClient = new Fabric8FlinkKubeClient(flinkConfig,
kubeClient);
+ flinkKubeClient = new Fabric8FlinkKubeClient(
+ flinkConfig,
+ kubeClient,
+ Executors::newDirectExecutorService);
Review comment:
`Fabric8FlinkKubeClientTest` uses a direct executor which technically allows
not to call `get()` on the pod creation/stop futures in the corresponding
tests. I would still call `get()` to avoid confusion in case of any future
executor refactorings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
