[
https://issues.apache.org/jira/browse/FLINK-17053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078331#comment-17078331
]
Piotr Nowojski commented on FLINK-17053:
----------------------------------------
SNAFU, bad mockito test exploded. After [~wenlong.lwl] change, either
requestBufferBuilderBlocking or requestBufferBuilder can be called
inter-exchangeably. Test has to be rewritten to drop the mockito usage.
I'm reverting FLINK-16864 for now.
> RecordWriterTest.testClearBuffersAfterInterruptDuringBlockingBufferRequest
> fails
> --------------------------------------------------------------------------------
>
> Key: FLINK-17053
> URL: https://issues.apache.org/jira/browse/FLINK-17053
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Network
> Affects Versions: 1.11.0
> Reporter: Robert Metzger
> Priority: Critical
> Labels: test-stability
> Fix For: 1.11.0
>
>
> CI run: https://travis-ci.org/github/apache/flink/jobs/672458481
> {code}
> [ERROR] Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 2.378 s <<< FAILURE! - in
> org.apache.flink.runtime.io.network.api.writer.BroadcastRecordWriterTest
> [ERROR]
> testClearBuffersAfterInterruptDuringBlockingBufferRequest(org.apache.flink.runtime.io.network.api.writer.BroadcastRecordWriterTest)
> Time elapsed: 1.197 s <<< FAILURE!
> Wanted but not invoked:
> bufferProvider.requestBufferBuilderBlocking();
> -> at
> org.apache.flink.runtime.io.network.api.writer.RecordWriterTest.testClearBuffersAfterInterruptDuringBlockingBufferRequest(RecordWriterTest.java:211)
> However, there were exactly 2 interactions with this mock:
> bufferProvider.requestBufferBuilder();
> -> at
> org.apache.flink.runtime.io.network.api.writer.RecordWriterTest$RecyclingPartitionWriter.tryGetBufferBuilder(RecordWriterTest.java:726)
> bufferProvider.requestBufferBuilder();
> -> at
> org.apache.flink.runtime.io.network.api.writer.RecordWriterTest$RecyclingPartitionWriter.tryGetBufferBuilder(RecordWriterTest.java:726)
> at
> org.apache.flink.runtime.io.network.api.writer.RecordWriterTest.testClearBuffersAfterInterruptDuringBlockingBufferRequest(RecordWriterTest.java:211)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
