wangyang0918 commented on a change in pull request #11639:
[FLINK-16626][runtime] Prevent REST handler from being closed more than once
URL: https://github.com/apache/flink/pull/11639#discussion_r405952615
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java
##########
@@ -221,7 +227,12 @@ private void finalizeRequestProcessing(FileUploads
uploadedFiles) {
@Override
public final CompletableFuture<Void> closeAsync() {
- return FutureUtils.composeAfterwards(closeHandlerAsync(),
inFlightRequestTracker::awaitAsync);
+ if (isHandlerClosed.compareAndSet(false, true)) {
+ return
FutureUtils.composeAfterwards(closeHandlerAsync(),
inFlightRequestTracker::awaitAsync);
+ } else {
+ log.warn("The handler instance for {} had already been
closed, but another attempt at closing it was made.",
untypedResponseMessageHeaders.getTargetRestEndpointURL());
+ return CompletableFuture.completedFuture(null);
Review comment:
@keijiyoshida I agree with you that the root cause is accidentally reusing
the handler instance. However, we have checked the duplication in
`RestServerEndpoint`, i am just think whether we still need to have the
defensive logics here.
I do not insist of this. You could determine by yourself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
