[
https://issues.apache.org/jira/browse/FLINK-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058174#comment-15058174
]
ASF GitHub Bot commented on FLINK-2882:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1455#issuecomment-164790880
Looks very good.
I am wondering if we can get rid of the toShortString method. What is that
one actually used for?
> Improve performance of string conversions
> -----------------------------------------
>
> Key: FLINK-2882
> URL: https://issues.apache.org/jira/browse/FLINK-2882
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.10.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
>
> {{AbstractID.toString()}} and {{AbstractID.toShortString()}} call
> {{StringUtils.byteToHexString(...)}} which uses a StringBuilder to convert
> from binary to hex. This is a hotspot when scaling the number of workers.
> While testing on my single node with parallelism=512 jvisualvm reports
> 600,000 calls taking 13.4 seconds. Improving
> {{StringUtils.byteToHexString(...)}} reduces the time to 1.3 seconds.
> Additionally memoizing the string values in {{AbstractID}} reduce the time to
> 350 ms and the number of calls to {{StringUtils.byteToHexString(...)}} to
> ~1000.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
