pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406774796
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -114,13 +119,25 @@ public boolean add(BufferConsumer bufferConsumer) {
return add(bufferConsumer, false);
}
+ @Override
+ public boolean add(BufferConsumer bufferConsumer, boolean
isPriorityEvent) {
Review comment:
`isPriorityEvent == true` seems like it's not tested in any way. While there
should be a test at least for checking that's enqueued at the head AND that
data notification was issued.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
