zhengcanbin opened a new pull request #11707: [FLINK-15648][k8s] Introduce CPU limit support for JM/TM Container URL: https://github.com/apache/flink/pull/11707 ## What is the purpose of the change Currently, we use `kubernetes.jobmanager(taskmanager).cpu` to configure CPU request and CPU limit at the same time for the JM/TM Container; given that people are asking for different request and limit values for the sake of elasticity, this PR proposes to separate these two configurations, people can set the CPU limit separately via new config options `kubernetes.jobmanager(taskmanager).cpu.limit`. ## Brief change log - Introduce new config option `kubernetes.jobmanager.cpu.limit` - Introduce new config option `kubernetes.taskmanager.cpu.limit` ## Verifying this change This change added tests and could be covered by existing tests. ## Open questions K8s allows us to set CPU request or limit to zero for a Container. After this PR, - JobManager CPU limit allows zero value - TaskManager CPU limit allows zero value - JobManager CPU request allows zero value - But TaskManager CPU request does not allow zero value, this is somewhat inconsistent with K8s or the JobManager side, at the moment I think it is a trivial problem, but we can support it if necessary; welcome any feedback on this issue. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (yes) - If yes, how is the feature documented? (docs)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
