[jira] [Commented] (FLINK-3180) MemoryLogger does not log direct memory

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062407#comment-15062407
 ] 

ASF GitHub Bot commented on FLINK-3180:
---------------------------------------

Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/1466#issuecomment-165524534
  
    I've added some related changes to this PR to display the direct memory 
usage in the web frontend as well. The current structure didn't make a lot of 
sense to me:
    
    ## Current
    
    ![screen shot 2015-12-17 at 17 28 
42](https://cloud.githubusercontent.com/assets/1756620/11876983/cf7b5280-a4ec-11e5-9a06-67075ad5a34a.png)
    
    ## This PR
    
    ![screen shot 2015-12-17 at 18 26 
00](https://cloud.githubusercontent.com/assets/1756620/11876991/dd456c98-a4ec-11e5-840c-1653fc393698.png)
    
    It's not that beautiful, but I think the ordering makes more sense now. 
I've also fixed a bug with the reporting of the PS-Scavenge GC times.
    
    (PS: Sorry for overloading this PR.)
    
    @mxm Is it OK if we address your comment in a follow up? I'm not sure how 
the respective bean is initialized and how expensive it is. In contrast to the 
other beans, this is not just a getter which initializes the bean on first 
access.


> MemoryLogger does not log direct memory
> ---------------------------------------
>
>                 Key: FLINK-3180
>                 URL: https://issues.apache.org/jira/browse/FLINK-3180
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Runtime
>    Affects Versions: 0.10.1
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>             Fix For: 0.10.2, 1.00
>
>
> The {{MemoryLogger}} logs {{MemoryPoolMXBean}} outputs. These do not contain 
> the direct memory. I think this was assumed to be the case.
> We have to query the MBeanServer manually for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)