simplejason commented on a change in pull request #11731: [FLINK-17130][web]
Enable listing JM Logs and displaying Logs by filename
URL: https://github.com/apache/flink/pull/11731#discussion_r408120348
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job-manager/log-detail/job-manager-log-detail.component.html
##########
@@ -16,5 +16,21 @@
~ limitations under the License.
-->
+<div class="breadcrumb">
+ <nz-breadcrumb>
+ <nz-breadcrumb-item>
+ <a [routerLink]="['../']"><i nz-icon type="rollback"
theme="outline"></i> Log List</a>
+ </nz-breadcrumb-item>
+ <nz-breadcrumb-item>
+ {{ logName }}
+ </nz-breadcrumb-item>
+ </nz-breadcrumb>
+ <flink-refresh-download
+ [isLoading]="isLoading"
+ [downloadHref]="downloadUrl"
+ [downloadName]="logName"
+ (reload)="reload()"
+ (fullScreen)="toggleFullScreen($event)">
+ </flink-refresh-download>
+</div>
<flink-monaco-editor [value]="logs"></flink-monaco-editor>
Review comment:
When I scroll the log content, a border appears at the top of the editor, I
think it would be nice to hide it, but it's also ok if we want to keep it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
