tillrohrmann commented on a change in pull request #10228: [FLINK-14816] Add
thread dump feature for taskmanager
URL: https://github.com/apache/flink/pull/10228#discussion_r408282968
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/FileType.java
##########
@@ -22,6 +22,18 @@
* Different file types to request from the {@link TaskExecutor}.
*/
public enum FileType {
+ /**
+ * the log file type for taskmanager
+ */
LOG,
- STDOUT
+
+ /**
+ * the stdout file type for taskmanager
+ */
+ STDOUT,
+
+ /**
+ * the thread dump type for taskmanager
+ */
+ THREAD_DUMP
Review comment:
Instead of introducing a new `FileType`, how about introducing a separate
`TaskExecutorGateway#requestThreadDump` method? This would give the operation a
more expressive name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
