Myasuka opened a new pull request #11742: [FLINK-16770][checkpoint] Avoid dispose checkpoint during async finalization of pendingcheckpoint URL: https://github.com/apache/flink/pull/11742 ## What is the purpose of the change This is a quick hot-fix of FLINK-16770, which would not remove checkpoint by mistake but would let checkpoint could complete after job switched to cancelling status. However, this should not introduce harmful influence. ## Brief change log Refactor the logic of `PendingCheckpoint#dispose` and `PendingCheckpoint#finalizeCheckpoint` so that they are exclusive from each other. ## Verifying this change This change added tests and can be verified as follows: - Refactor `PendingCheckpoint#testAbortingDuringAsyncFinalization` to verify not discard checkpoint when already in async phase of finalize checkpoint. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers:no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
