dianfu commented on a change in pull request #11749: [FLINK-16669][python][table] Support Python UDF in SQL function DDL. URL: https://github.com/apache/flink/pull/11749#discussion_r409265142
########## File path: flink-python/src/main/java/org/apache/flink/client/python/PythonFunctionFactoryUtil.java ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.client.python; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.configuration.ReadableConfig; + +import py4j.GatewayServer; + +import java.io.File; +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.UUID; +import java.util.concurrent.ExecutionException; + +import static org.apache.flink.client.python.PythonEnvUtils.getGatewayServer; +import static org.apache.flink.client.python.PythonEnvUtils.launchPy4jPythonClient; +import static org.apache.flink.client.python.PythonEnvUtils.setGatewayServer; +import static org.apache.flink.client.python.PythonEnvUtils.shutdownPythonProcess; + +/** + * Utils for PythonFunctionFactory. + */ +public class PythonFunctionFactoryUtil { + + private static final long CHECK_INTERVAL = 100; + + private static final long TIMEOUT_MILLIS = 3000; + + private static PythonFunctionFactory pythonFunctionFactory = null; + + @VisibleForTesting + static Thread pythonProcessShutdownHook = null; + + public static synchronized PythonFunctionFactory getPythonFunctionFactory(ReadableConfig config) + throws IOException, ExecutionException, InterruptedException { + if (pythonFunctionFactory != null) { + return pythonFunctionFactory; + } else { + if (getGatewayServer() == null) { Review comment: If pythonFunctionFactory is null, the gateway server should also be null. Do I missed something? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
