tillrohrmann commented on a change in pull request #11363:
[FLINK-16440][runtime] Extend SlotManager metrics and status for dynamic slot
allocation.
URL: https://github.com/apache/flink/pull/11363#discussion_r409661867
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/StandaloneResourceManagerFactory.java
##########
@@ -28,31 +28,35 @@
import org.apache.flink.runtime.metrics.groups.ResourceManagerMetricGroup;
import org.apache.flink.runtime.rpc.FatalErrorHandler;
import org.apache.flink.runtime.rpc.RpcService;
+import org.apache.flink.util.ConfigurationException;
import javax.annotation.Nullable;
/**
* {@link ResourceManagerFactory} which creates a {@link
StandaloneResourceManager}.
*/
-public enum StandaloneResourceManagerFactory implements
ResourceManagerFactory<ResourceID> {
Review comment:
I guess it wouldn't have been necessary to change the enum to a class. Enums
are the preferred way to implement singletons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
