[
https://issues.apache.org/jira/browse/FLINK-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069813#comment-15069813
]
ASF GitHub Bot commented on FLINK-3103:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1474#issuecomment-166934557
As some context: The class does not lock on all calls that can modify the
state of the buffers (such as every `write()` call, for performance), so the
locking removed in this PR becomes not effective anyways.
+1, will merge this...
> Remove synchronization in FsStateBackend#FsCheckpointStateOutputStream#close()
> ------------------------------------------------------------------------------
>
> Key: FLINK-3103
> URL: https://issues.apache.org/jira/browse/FLINK-3103
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
>
> Here is related code:
> {code}
> public void flush() throws IOException {
> if (!closed) {
> {code}
> Lock "FsCheckpointStateOutputStream.this" should be held.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
