pnowojski commented on a change in pull request #11687:
[FLINK-16536][network][checkpointing] Implement InputChannel state recovery for
unaligned checkpoint
URL: https://github.com/apache/flink/pull/11687#discussion_r410226251
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -213,19 +215,23 @@ public SingleInputGate(
}
@Override
- public void setup() throws IOException, InterruptedException {
+ public void setup() throws IOException {
Review comment:
> The previous assumption was that the output recovery should execute
earlier than the input recovery in order to occupy more floating buffers from
global, to get the benefit to speedup recovery process. Now the output recovery
is executed by task thread during StreamTask#beforeInvoke. If we integrate the
input recovery within setup process, then it would perform before output
recovery to occupy more floating buffers in limited buffers environment.
Ok, I haven't considered that. I guess it's best to keep it as it is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
