zhijiangW commented on a change in pull request #11786: [FLINK-17208][network]
Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#discussion_r410362251
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -146,7 +149,10 @@ private boolean add(BufferConsumer bufferConsumer,
boolean finish, boolean inser
handleAddingBarrier(bufferConsumer, insertAsHead);
updateStatistics(bufferConsumer);
increaseBuffersInBacklog(bufferConsumer);
- notifyDataAvailable = insertAsHead || finish ||
shouldNotifyDataAvailable();
+
+ // Notify only when we added first finished buffer.
+ notifyDataAvailable = mayNotifyDataAvailable() &&
getNumberOfFinishedBuffers() == 1;
+ dataAvailableNotified = dataAvailableNotified ||
notifyDataAvailable;
Review comment:
it is not easy to identify `dataAvailableNotified` with
`notifyDataAvailable` together. How about renaming `dataAvailableNotified` as
`alreadyNotified` and `notifyDataAvailable` as `shouldNotify`, which might seem
more clearly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
