xintongsong commented on a change in pull request #11353: [FLINK-16438][yarn]
Make YarnResourceManager starts workers using WorkerResourceSpec requested by
SlotManager
URL: https://github.com/apache/flink/pull/11353#discussion_r410858435
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/RegisterApplicationMasterResponseReflectorTest.java
##########
@@ -88,7 +94,44 @@ public void testGetMethodReflectiveHadoop22() {
final RegisterApplicationMasterResponseReflector
registerApplicationMasterResponseReflector =
new RegisterApplicationMasterResponseReflector(LOG);
- final Method method =
registerApplicationMasterResponseReflector.getMethod();
+ final Method method =
registerApplicationMasterResponseReflector.getGetContainersFromPreviousAttemptsMethod();
+ assertThat(method, notNullValue());
+ }
+
+ @Test
+ public void testCallsGetSchedulerResourceTypesMethodIfPresent() {
+ final RegisterApplicationMasterResponseReflector
registerApplicationMasterResponseReflector =
+ new RegisterApplicationMasterResponseReflector(LOG,
HasMethod.class);
+
+ final Optional<Set<String>> schedulerResourceTypeNames =
+
registerApplicationMasterResponseReflector.getSchedulerResourceTypeNamesUnsafe(new
HasMethod());
Review comment:
I'm not sure about this. My concern is that, the <2.6 test case might
eventually not executed in most cases.
Take `testDoesntCallGetContainersFromPreviousAttemptsMethodIfAbsent` as an
example. If we make this test case only executed with Hadoop <2.2, then it's
practically not executed. Currently we have Hadoop 2.8 for travis ci test, 2.4
& 2.8 for nightly test, and 2.4 (pom default) for local maven verify unless
another version is intentionally specified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
