wangyang0918 commented on a change in pull request #11010:
URL: https://github.com/apache/flink/pull/11010#discussion_r411092429
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManager.java
##########
@@ -91,6 +93,8 @@
/** The number of pods requested, but not yet granted. */
private int numPendingPodRequests = 0;
+ private KubernetesWatch podsWatch;
Review comment:
Thanks a lot for kicking off this discussion. When i introduce these
wrappers `KubernetesPod`, `KubernetesService`, `KubernetesToleration`,
`KubernetesWatch` and `PodCallbackHandler`, i am just to limit the fabric8
specific classes in the package `org.apache.flink.kubernetes.kubeclient`. So
then when we migrate to other kubernetes-client implementation, we will not
have to change too many classes that have concrete logics. Another benefit is
we could add some specific method for the wrapper resource(e.g.
KubernetesPod#isTerminated).
It is a pity that we still have few fabric8 classes in `KubernetesUtils`.
But i think it could be easily factored out if we want.
It is just my personal thoughts and i could rethink it if some others also
have the same concerns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
