dianfu commented on a change in pull request #11768:
URL: https://github.com/apache/flink/pull/11768#discussion_r411828146
##########
File path: docs/dev/table/python/dependency_management.md
##########
@@ -22,7 +22,24 @@ specific language governing permissions and limitations
under the License.
-->
-If third-party dependencies are used, you can specify the dependencies with
the following Python Table APIs or through <a href="{{ site.baseurl
}}/ops/cli.html#usage">command line arguments</a> directly when submitting the
job.
+# Java Dependency Management
Review comment:
What about `Java Dependency`?
##########
File path: docs/dev/table/python/dependency_management.md
##########
@@ -22,7 +22,24 @@ specific language governing permissions and limitations
under the License.
-->
-If third-party dependencies are used, you can specify the dependencies with
the following Python Table APIs or through <a href="{{ site.baseurl
}}/ops/cli.html#usage">command line arguments</a> directly when submitting the
job.
+# Java Dependency Management
+
+If third-party Java dependencies are used, you can using following code to add
jars for your Python job.
+
+{% highlight python %}
+# Set jar urls in "pipeline.jars". The jars will be uploaded to the cluster.
+# NOTE: Only local file urls (start with "file://") are supported.
+table_env.get_config.set_configuration("pipeline.jars",
"file:///my/jar/path/connector.jar;file:///my/jar/path/udf.jar")
+
+# Set jar urls in "pipeline.classpaths". The jars will be added to the
classpath of the cluster.
+# Users should ensure the urls are accessible on both the local client and the
cluster.
+# NOTE: The supported schemes includes: file,ftp,http,https,jar. "hdfs" is not
supported by default.
+table_env.get_config.set_configuration("pipeline.classpaths",
"file:///my/jar/path/connector.jar;file:///my/jar/path/udf.jar")
+{% endhighlight %}
+
+# Python Dependency Management
Review comment:
What about `Python Dependency`?
##########
File path: docs/dev/table/python/dependency_management.md
##########
@@ -22,7 +22,24 @@ specific language governing permissions and limitations
under the License.
-->
-If third-party dependencies are used, you can specify the dependencies with
the following Python Table APIs or through <a href="{{ site.baseurl
}}/ops/cli.html#usage">command line arguments</a> directly when submitting the
job.
+# Java Dependency Management
+
+If third-party Java dependencies are used, you can using following code to add
jars for your Python job.
Review comment:
Users could also specify the Java dependencies via command line
arguments, could we add a link for that?
##########
File path: docs/dev/table/python/dependency_management.md
##########
@@ -22,7 +22,24 @@ specific language governing permissions and limitations
under the License.
-->
-If third-party dependencies are used, you can specify the dependencies with
the following Python Table APIs or through <a href="{{ site.baseurl
}}/ops/cli.html#usage">command line arguments</a> directly when submitting the
job.
+# Java Dependency Management
+
+If third-party Java dependencies are used, you can using following code to add
jars for your Python job.
+
+{% highlight python %}
+# Set jar urls in "pipeline.jars". The jars will be uploaded to the cluster.
+# NOTE: Only local file urls (start with "file://") are supported.
+table_env.get_config.set_configuration("pipeline.jars",
"file:///my/jar/path/connector.jar;file:///my/jar/path/udf.jar")
+
+# Set jar urls in "pipeline.classpaths". The jars will be added to the
classpath of the cluster.
Review comment:
`Set jar urls in "pipeline.classpaths"` -> `Specify a list of jar URLs
via "pipeline.classpaths"`
##########
File path: docs/dev/table/python/dependency_management.md
##########
@@ -22,7 +22,24 @@ specific language governing permissions and limitations
under the License.
-->
-If third-party dependencies are used, you can specify the dependencies with
the following Python Table APIs or through <a href="{{ site.baseurl
}}/ops/cli.html#usage">command line arguments</a> directly when submitting the
job.
+# Java Dependency Management
+
+If third-party Java dependencies are used, you can using following code to add
jars for your Python job.
+
+{% highlight python %}
+# Set jar urls in "pipeline.jars". The jars will be uploaded to the cluster.
+# NOTE: Only local file urls (start with "file://") are supported.
Review comment:
`Set jar urls in "pipeline.jars".` -> `Specify a list of jar URLs via
"pipeline.jars"`
##########
File path: docs/dev/table/python/dependency_management.md
##########
@@ -22,7 +22,24 @@ specific language governing permissions and limitations
under the License.
-->
-If third-party dependencies are used, you can specify the dependencies with
the following Python Table APIs or through <a href="{{ site.baseurl
}}/ops/cli.html#usage">command line arguments</a> directly when submitting the
job.
+# Java Dependency Management
+
+If third-party Java dependencies are used, you can using following code to add
jars for your Python job.
+
+{% highlight python %}
+# Set jar urls in "pipeline.jars". The jars will be uploaded to the cluster.
+# NOTE: Only local file urls (start with "file://") are supported.
+table_env.get_config.set_configuration("pipeline.jars",
"file:///my/jar/path/connector.jar;file:///my/jar/path/udf.jar")
+
+# Set jar urls in "pipeline.classpaths". The jars will be added to the
classpath of the cluster.
+# Users should ensure the urls are accessible on both the local client and the
cluster.
+# NOTE: The supported schemes includes: file,ftp,http,https,jar. "hdfs" is not
supported by default.
Review comment:
includes -> include
##########
File path: docs/dev/table/python/dependency_management.md
##########
@@ -22,7 +22,24 @@ specific language governing permissions and limitations
under the License.
-->
-If third-party dependencies are used, you can specify the dependencies with
the following Python Table APIs or through <a href="{{ site.baseurl
}}/ops/cli.html#usage">command line arguments</a> directly when submitting the
job.
+# Java Dependency Management
+
+If third-party Java dependencies are used, you can using following code to add
jars for your Python job.
+
+{% highlight python %}
+# Set jar urls in "pipeline.jars". The jars will be uploaded to the cluster.
+# NOTE: Only local file urls (start with "file://") are supported.
+table_env.get_config.set_configuration("pipeline.jars",
"file:///my/jar/path/connector.jar;file:///my/jar/path/udf.jar")
+
+# Set jar urls in "pipeline.classpaths". The jars will be added to the
classpath of the cluster.
+# Users should ensure the urls are accessible on both the local client and the
cluster.
+# NOTE: The supported schemes includes: file,ftp,http,https,jar. "hdfs" is not
supported by default.
Review comment:
NOTE: Paths must specify a protocol (e.g. file://) and users should
ensure that the URLs are accessible on both the client and the cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
