dianfu commented on a change in pull request #11836:
URL: https://github.com/apache/flink/pull/11836#discussion_r412054251



##########
File path: flink-python/dev/lint-python.sh
##########
@@ -244,6 +244,7 @@ function install_py_env() {
 # Install tox.
 # In some situations,you need to run the script with "sudo". e.g. sudo 
./lint-python.sh
 function install_tox() {
+    source ${CONDA_HOME}/bin/activate

Review comment:
       Both of these two styles work. Just want to keep the style consistent as 
much as possible. Currently most places use $VAR instead of ${VAR}.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to