KarmaGYZ commented on a change in pull request #11855: URL: https://github.com/apache/flink/pull/11855#discussion_r412792582
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/IntermediateResultPartitionID.java ########## @@ -27,29 +28,76 @@ /** * Id identifying {@link IntermediateResultPartition}. */ -public class IntermediateResultPartitionID extends AbstractID implements ResultID { +public class IntermediateResultPartitionID implements Comparable<IntermediateResultPartitionID>, ResultID, java.io.Serializable { Review comment: First of all, `AbstractID` implements this inferface. I do not remember which class compare the `IntermediateResultPartitionID` but I do encounter issue when I did not implement this at the first time. It may take me some time to find it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org