[ 
https://issues.apache.org/jira/browse/FLINK-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089141#comment-15089141
 ] 

ASF GitHub Bot commented on FLINK-3192:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1477#discussion_r49183864
  
    --- Diff: 
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/explain/PlanJsonParser.java
 ---
    @@ -0,0 +1,148 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.table.explain;
    +
    +import com.fasterxml.jackson.databind.ObjectMapper;
    +import com.fasterxml.jackson.databind.DeserializationFeature;
    +
    +import java.io.PrintWriter;
    +import java.io.StringWriter;
    +import java.util.LinkedHashMap;
    +import java.util.List;
    +
    +public class PlanJsonParser {
    +   
    +   public static String getSqlExecutionPlan(String t, boolean extended) 
throws Exception{
    +           StringWriter sw = new StringWriter();
    +           PrintWriter pw = new PrintWriter(sw);
    +           buildSqlExecutionPlan(t, extended, pw);
    +           pw.close();
    +           return sw.toString();
    +   }
    +
    +   private static void printTab(int tabCount, PrintWriter pw) {
    +           for (int i = 0; i < tabCount; i++)
    +                   pw.print("\t");
    +   }
    +
    +   private static void buildSqlExecutionPlan(String t, Boolean extended, 
PrintWriter pw) throws Exception {
    --- End diff --
    
    I think we can merge `buildSqlExecutionPlan` and `getSqlExecutionPlan` into 
a single method.


> Add explain support to print ast and sql physical execution plan. 
> ------------------------------------------------------------------
>
>                 Key: FLINK-3192
>                 URL: https://issues.apache.org/jira/browse/FLINK-3192
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API
>            Reporter: GaoLun
>            Assignee: GaoLun
>            Priority: Minor
>              Labels: features
>
> Table API doesn't support sql-explanation now. Add the explain support to 
> print ast (abstract syntax tree) and the physical execution plan of sql.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to