danny0405 commented on a change in pull request #11791:
URL: https://github.com/apache/flink/pull/11791#discussion_r414314520
##########
File path: flink-table/flink-sql-parser/pom.xml
##########
@@ -298,6 +348,23 @@ under the License.
<outputDirectory>${project.build.directory}/generated-sources/</outputDirectory>
</configuration>
</execution>
+ <execution>
+ <phase>generate-sources</phase>
+ <id>javacc-hive</id>
+ <goals>
+ <goal>javacc</goal>
+ </goals>
+ <configuration>
+
<sourceDirectory>${project.build.directory}/generated-sources-hive/</sourceDirectory>
Review comment:
The plugin is a mess, can we just create another module instead put the
code in one ? And why we copy the parser file of Flink, it seems there is no
any reuse parse code block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
