godfreyhe commented on a change in pull request #11397:
URL: https://github.com/apache/flink/pull/11397#discussion_r415259812
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
##########
@@ -196,8 +196,12 @@ public void open() {
if (line == null) {
continue;
}
- final Optional<SqlCommandCall> cmdCall =
parseCommand(line);
- cmdCall.ifPresent(this::callCommand);
+ try {
+ final Optional<SqlCommandCall> cmdCall =
parseCommand(line);
+ cmdCall.ifPresent(this::callCommand);
+ } catch (Throwable t) {
Review comment:
@twalthr `catch Throwable` is removed. instead, I catch
ValidationException and throw SqlExecutionException when enriching properties,
and check all `callXX` methods in CliClient to make sure all
SqlExecutionExceptions are caught.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
