dianfu commented on a change in pull request #11915:
URL: https://github.com/apache/flink/pull/11915#discussion_r415511471



##########
File path: tools/releasing/create_binary_release.sh
##########
@@ -109,14 +112,30 @@ make_python_release() {
 
   cp ${pyflink_actual_name} "${RELEASE_DIR}/${pyflink_release_name}"
 
+  # RM need to move the downloaded wheel packages from Azure CI to the 
directory of flink-python/dist manually.
+  for wheel_file in *.whl; do
+    if [[ ! ${wheel_file} =~ ^apache_flink-$PYFLINK_VERSION- ]]; then

Review comment:
       So the name of the wheel package is `apache_flink-version.whl` instead 
of `apache-flink-version.whl`?

##########
File path: tools/releasing/create_binary_release.sh
##########
@@ -94,7 +94,10 @@ make_python_release() {
   cd flink-python/
   # use lint-python.sh script to create a python environment.
   dev/lint-python.sh -s basic
+  set +eu

Review comment:
       Why we need this change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to