xintongsong commented on a change in pull request #11916: URL: https://github.com/apache/flink/pull/11916#discussion_r415523468
########## File path: flink-yarn/src/main/java/org/apache/flink/yarn/WorkerSpecContainerResourceAdapter.java ########## @@ -71,52 +72,65 @@ } Optional<Resource> tryComputeContainerResource(final WorkerResourceSpec workerResourceSpec) { - return Optional.ofNullable(workerSpecToContainerResource.computeIfAbsent( + final InternalContainerResource internalContainerResource = workerSpecToContainerResource.computeIfAbsent( Preconditions.checkNotNull(workerResourceSpec), - this::createAndMapContainerResource)); + this::createAndMapContainerResource); + if (internalContainerResource != null) { + return Optional.of(internalContainerResource.toResource()); + } else { + return Optional.empty(); + } } Set<WorkerResourceSpec> getWorkerSpecs(final Resource containerResource, final MatchingStrategy matchingStrategy) { - return getEquivalentContainerResource(containerResource, matchingStrategy).stream() + final InternalContainerResource internalContainerResource = new InternalContainerResource(containerResource); + return getEquivalentInternalContainerResource(internalContainerResource, matchingStrategy).stream() Review comment: Same here. I'd like to make it explicit that `Resource` is only used in arguments and return values of methods visible from outside, and everywhere else should use `InternalContainerResource`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org